Wireshark-bugs: [Wireshark-bugs] [Bug 12007] editcap packet comment won't add multiple comments

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 14 Jan 2016 05:10:05 +0000

Comment # 6 on bug 12007 from 
(In reply to Michael Mann from comment #5)
> Because it had a incomplete compare function.  Review adjusted accordingly.

*Incorrect* compare function; it's a correct function for a hash table, where
the comparison function only needs to check for equality, but it's wrong for a
tree, where it needs to check for order.  As a result, it should be renamed to
reflect reality (and the comment about g_direct_equal() removed).

You are receiving this mail because:
  • You are watching all bug changes.