Comment # 5
on bug 11369
from [email protected]
(In reply to Jeff Morriss from comment #4)
> (In reply to arthur.yurov from comment #3)
> > I've posted a side by side view of the Legacy UI and the new UI of what it
> > looks like when I filter by our protocol name. I also demonstrate in this
> > screenshot that the details of the packet are still properly displayed, the
> > only issues exist in the packet info of the header at the top.
>
> OK so this isn't (just) about "show packet in new window."
>
> Does it display properly when there's no display filter?
>
> If so, do you have some if(tree) checks in the code? They're largely
> unnecessary now.
If there was no display filter, the header part (I don't know the terminology
here for the top section) displayed correctly, this was how it was originally
presented to us by QA, they found it via using "Show packet in new window" but
it seemed to happen just by filtering by the protocol.
We had a few "if (tree)" checks. Removing them and recompiling the plugin
(still 1.99.3) fixes the entire issue. Filtering, showing packet in new window,
works perfectly fine in both the Legacy version and new version of the UI. So
it was actually because of this, which forces me to ask what changed that
causes "if (tree)" checks to be unnecessary? Are we always getting a tree from
Wireshark now, and it's never null?
And follow-up, are there any resources you can point to that better lists and
explains these sort of changes?
You are receiving this mail because:
- You are watching all bug changes.