Wireshark-bugs: [Wireshark-bugs] [Bug 11419] 802.11ad Decoding Error

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 05 Aug 2015 20:17:33 +0000

Comment # 4 on bug 11419 from 
Yeah, there are a bunch of proto_tree_add_item() calls that are adding
numerical bitfield values from a multi-byte field and that are using ENC_NA.

This Is An Error - ENC_NA should not be used for multi-byte numerical values,
as in that context it's treated as ENC_BIG_ENDIAN (as it has the same value as
ENC_BIG_ENDIAN), and either

    1) the field really *is* big-endian, and the call should say so

or

    2) the field *isn't* big-endian, and the call should use ENC_LITTLE_ENDIAN.

This also applies to subfields of a multi-byte field containing bitfields.

The subfields of the Sector Sweep field are among the fields incorrectly added
with ENC_NA.

I'm reviewing packet-ieee80211.c to at least find the obvious errors of that
sort.

You are receiving this mail because:
  • You are watching all bug changes.