Wireshark-bugs: [Wireshark-bugs] [Bug 11356] Wireshark Lua dissectors: both expand together

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 13 Jul 2015 01:57:23 +0000

changed bug 11356


What Removed Added
Status UNCONFIRMED IN_PROGRESS
CC   [email protected]
Assignee [email protected] [email protected]
Ever confirmed   1

Comment # 2 on bug 11356 from 
(In reply to Guy Harris from comment #1)
> proto1 and proto2 are probably being given a common ett_ value.
> 
> It looks as if the Wireshark Lua code doesn't assign any ett_ values, which
> means all protocol tree entries use the common wslua_ett, so they are all
> flagged as "expand" or "contract" together.
> 
> It should probably be assigning individual ett_ values for fields.

Yup, that was the bug - I've already written the fix and tested it. I could
have sworn I had done it before a long time ago, but apparently what I did
before was assign each of the protocol's *fields* an ett, but not the protocol
itself. So it actually stayed at -1, and wslua's tree add code used a common
"wslua_ett" if it was -1.

You are receiving this mail because:
  • You are watching all bug changes.