Wireshark-bugs: [Wireshark-bugs] [Bug 11344] Mysql dissector adds packet content to INFO column

Date: Tue, 07 Jul 2015 02:26:31 +0000

Comment # 2 on bug 11344 from
(In reply to Michael Mann from comment #1)
> I think this may be a bigger problem.... See bug 10284 as just another
> example.

Oh I'm sure some other protocols do what the MySQL one did too. I'm just fixing
this one because it was raised on ask.wireshark.org. :)

I'd argue the mDNS bug is different - it should be perfectly ok for dissectors
to put double-quotes and commas and such in the INFO column. But tshark should
make the strings ok for CSV when it outputs into CSV. Unfortunately, as you're
no doubt aware, it doesn't actually know it's generating CSV; it just knows the
user asked for a comma separator character between output fields.

Ultimately tshark should have a command-line option to explicitly output CSV,
and have the code fix the string automatically in the "printer"; i.e., another
arg type for the '-T' switch.  Wireshark seems to do that, calling
csv_write_str()/csv_massage_str() eventually.

Although looking at csv_massage_str(), it's got problems too. It can produce
invalid CSV. :(


You are receiving this mail because:
  • You are watching all bug changes.