Wireshark-bugs: [Wireshark-bugs] [Bug 10971] CANopen dissector does not support CAN2.0B extended

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 23 Apr 2015 02:30:50 +0000

changed bug 10971


What Removed Added
CC   [email protected]

Comment # 6 on bug 10971 from 
Created attachment 13571 [details]
CAN2.0B extended support

Martin,

Is this something close to what you want?  First I want to make sure I
understand the spec and the definition of "extended format".

The next issue is how to determine "extended format".  The socketCAN dissector
where this is coming from strips off the "extended format" bit when passing the
CAN ID to subdissectors.  I was a worried that format of CAN ID didn't extend
beyond socketCAN, and that CAN dissectors would only deal with 29 or 11 bit CAN
ids.  Usually the protocol/dissector only uses one.

So this patch "hardcodes" the assumption of a 29 bit CAN ID (just for testing),
but I would probably make it a dissector preference so as to not rely on the
"socketCAN format".

One of the other reasons I was hestitant to push this patch to Gerrit is this
change resulted in a lot of unknown function codes.  Is that just because the
current dissector has a limited number of CANOpen objects it supports?

You are receiving this mail because:
  • You are watching all bug changes.