Wireshark-bugs: [Wireshark-bugs] [Bug 11134] CORBA dissectors show malformed packet errors for v

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 22 Apr 2015 03:00:36 +0000

Comment # 12 on bug 11134 from 
(In reply to Guy Harris from comment #11)
> Does having One Less Argument To Pass warrant the abstraction?  If people
> just reflexively pass tvb_reported_length(tvb) or tvb_captured_length(tvb),
> why not just swallow that into the routine?

Ya, that's true. I guess my instinct was that most protocols shouldn't claim
their payloads, so e.g. TCP shouldn't be passing -1 or tvb_reported_length() or
anything like that, it should be passing 20 (or more, adjusting for options).
However, I expect the ship sailed on that debate a long time ago :)

It's a bit hard to tell with just grep and friends, but it does appear that
most protocols simply pass -1 already.

You are receiving this mail because:
  • You are watching all bug changes.