[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	10750
Summary	Use of GdkPixdata / gdk_pixbuf_new_from_inline deprecated in gdk-pixbuf 2.31.2
Product	Wireshark
Version	1.12.2
Hardware	x86
OS	SuSE
Status	UNCONFIRMED
Severity	Normal
Priority	Low
Component	GTK+ UI
Assignee	bugzilla-admin@wireshark.org
Reporter	andreas.stieger@gmx.de

Created attachment 13303 [details]
complete build log

Build Information:
See attachments for complete build log and environment versions.
--
The gdk-pixbuf 2.31.2 release marked GdkPixdata as deprecated, including
gdk_pixbuf_new_from_inline. 
Wireshark builds with deprecated functions turned off by default, in this case
via GDK_PIXBUF_DISABLE_DEPRECATED.

See:
https://git.gnome.org/browse/gdk-pixbuf/commit/?id=48d76fb7f2d059013f5781b199245274998f05c9
https://git.gnome.org/browse/gdk-pixbuf/tree/NEWS?id=2.31.2#n5

This then creates the initial warning:
> ui_utils.c: In function 'window_icon_realize_cb':
> ui_utils.c:115:5: warning: implicit declaration of function 'gdk_pixbuf_new_from_inline' [-Wimplicit-function-declaration]
>     icon = gdk_pixbuf_new_from_inline(-1, wsicon_16_pb_data, FALSE, NULL);
>     ^

And this causes these warnings due to the implicit declaration:
> gui_utils.c:115:10: warning: assignment makes pointer from integer without a cast [enabled by default]
>     icon = gdk_pixbuf_new_from_inline(-1, wsicon_16_pb_data, FALSE, NULL);
>     ^

These fails are specific to openSUSE package which is set to fail on the
pointer cast:
> E: wireshark 64bit-portability-issue gui_utils.c:115, 117, 119, 121, 512
> E: wireshark 64bit-portability-issue main.c:1513, 1519, 1525, 1531
> E: wireshark 64bit-portability-issue prefs_layout.c:346, 347, 348, 349, 350, 351
> E: wireshark 64bit-portability-issue stock_icons.c:413, 425

This is with Wireshark 1.12.2 (release) on openSUSE Factory, but I see the same
code present in git.

---

      You are receiving this mail because:

• You are watching all bug changes.