Peter Wu
changed
bug 10686
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
IN_PROGRESS
|
| CC |
|
[email protected]
|
| Ever confirmed |
|
1
|
Comment # 3
on bug 10686
from Peter Wu
Giving a second thought to it, this patch[1] increases the peak memory usage
during dissection. It can be optimized as follows:
1. Clear the ClientHello message (freeing data as needed) and any hash
structures (just in case a capture contains garbage). Save the ClientHello
message when the extension is set.
2. The next expected message is the ServerHello. This is an authoritative
message that decides the TLS version to be used. If the extension is enabled,
initialize the hashes. Now the ClientHello message copy can be cleared (both
when the extension is available and not available).
Now whenever after step 2 the extension is enabled, update the hash with the
handshake data. After calculating the MS, one could free the hash structures
again.
[1]: https://code.wireshark.org/review/#/c/5168/3
You are receiving this mail because:
- You are watching all bug changes.