Wireshark-bugs: [Wireshark-bugs] [Bug 10545] "BROWSER" protocol registration done in smb-browse

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Wed, 08 Oct 2014 18:46:27 +0000

changed bug 10545


What Removed Added
Status UNCONFIRMED CONFIRMED
Ever confirmed   1
Severity Major Normal

Comment # 3 on bug 10545 from 
(In reply to Matthieu Patou from comment #2)
> See the title: 
> '"BROWSER" protocol
> registration done in smb-browse conflicts with the "BROWSER" protocol from
> the pidl generated dissector'

> Basically if we keep this name for the
> packet-smb-browse.c it prevents from updating the packet-dcerpc-browser.c
> using latest version of PIDL.

But the current name for the dissector in packet-dcerpc_browser.c is
"rpc_browser".  I had just presumed that was intentional or PIDL could generate
it that way.  I didn't realize it was "manually" changed (presumably because of
the conflict with smb_browser).  Overall it looks like the dissector was
manually created from the start and never went through the PIDL (based on the
lack of a "DO NOT EDIT" at the top of the dissector.)

This patch needs to be submitted to Gerrit regardless, but I think that all of
the SMB BROWSER filters should also be updated to match the changed "filter
name" of the dissector if that's the route we're going.

You are receiving this mail because:
  • You are watching all bug changes.