Jeff Morriss
changed
bug 7683
| What |
Removed |
Added |
| Status |
RESOLVED
|
CONFIRMED
|
| Resolution |
FIXED
|
---
|
Comment # 4
on bug 7683
from Jeff Morriss
(In reply to comment #3)
> What is the functional difference between tcp.segments and
> tcp.reassembled.data?
>
> They both provide the reassembled data, and I think this looks like a
> duplicate field.
> Or do I miss something here?
>
> The reason I ask is because I was thinking about this when
> implementing reassembled.length, but found the existing field
> (hf_fragments) sufficient for all practical use.
Looking at the code (but without it out) it certainly does appear to be a
duplicate. The only difference is that tcp.segments (hf_fragments) is FT_NONE
rather than FT_BYTES (I suppose that could/should be changed). The fact that
the new field is added with an explicit length (tvb_length()) rather than -1
doesn't matter.
I'd guess we should back out the new field. And contemplate what name should
be usd for the field; reassembled.data certainly is more obvious to me.
You are receiving this mail because:
- You are watching all bug changes.