| Bug ID |
9951
|
| Summary |
git commit hook isn't calling checkAPIs.pl with arguments for the dissectors
|
| Classification |
Unclassified
|
| Product |
Wireshark
|
| Version |
Git
|
| Hardware |
All
|
| OS |
All
|
| Status |
UNCONFIRMED
|
| Severity |
Normal
|
| Priority |
Low
|
| Component |
Dissection engine (libwireshark)
|
| Assignee |
[email protected]
|
| Reporter |
[email protected]
|
Build Information:
Paste the COMPLETE build information from "Help->About Wireshark", "wireshark
-v", or "tshark -v".
--
I recently made a change to packet-rtp.c and inappropriately included g_error()
in it, which the builbots caught during their run of checkAPIs.pl. But
checkAPIs.pl is supposed to catch such things for us before we submit, by being
invoked in the git pre-commit hook.
Apparently though, buildbots call checkAPIs.pl with extra arguments for
different cases... and for packet dissectors it calls it with a '-g abort'
argument, which is how it caught the g_error.
So the "bug" is that the pre-commit hook should invoke checAPIs.pl with that
argument too, for epan/packet-*.c files.
You are receiving this mail because:
- You are watching all bug changes.