Wireshark-bugs: [Wireshark-bugs] [Bug 9937] New: SDP should use encodings other than UTF-8 in so

Date: Fri, 28 Mar 2014 18:24:58 +0000
Bug ID 9937
Summary SDP should use encodings other than UTF-8 in some cases
Classification Unclassified
Product Wireshark
Version Git
Hardware All
OS All
Status UNCONFIRMED
Severity Normal
Priority Low
Component Dissection engine (libwireshark)
Assignee [email protected]
Reporter [email protected]

Build Information:
Current top of trunk
--
SDP currently uses UTF-8 for all strings, which is mostly the right thing to
do.

However, there's a "a=charset:<character set>" attribute, that "specifies the
character set to be used to display the session name and information data."
"The charset specified MUST be one of those registered with IANA, such as
ISO-8859-1.  The character set identifier is a US-ASCII string and MUST be
compared against the IANA identifiers using a case-insensitive comparison.  If
the identifier is not recognised or not supported, all strings that are
affected by it SHOULD be regarded as octet strings."

That probably means that there should be a variable used for the encoding in
some cases, defaulting to ENC_UTF_8|ENC_NA, and set based on that attribute.

The RFC also says

    SDP field names and attribute names use only the US-ASCII subset of UTF-8

The right thing to do there is probably not to use ENC_ASCII|ENC_NA, but to
check for octets with the 8th bit set and add an expert info (PI_PROTOCOL)
indicating that a non-ASCII string is being used for a field name or attribute
name.


You are receiving this mail because:
  • You are watching all bug changes.