Hadriel Kaplan
changed
bug 9909
| What |
Removed |
Added |
| Status |
RESOLVED
|
UNCONFIRMED
|
| Resolution |
FIXED
|
---
|
| Ever confirmed |
1
|
|
Comment # 15
on bug 9909
from Hadriel Kaplan
(In reply to comment #12)
> (In reply to comment #2)
> > I uploaded a short-term fix to prevent crashing:
> > https://code.wireshark.org/review/#/c/757/
> >
> > (not sure if anyone else is working on these related buildbot crash bugs or
> > not, since I can't set "IN_PROGRESS" for this bug)
>
> With my gdb is have :
> Program received signal SIGSEGV, Segmentation fault.
> add_tagged_field (pinfo=pinfo@entry=0x7fffffffcb48,
> tree=tree@entry=0x7fffa5280310,
> tvb=tvb@entry=0x244d940, offset=offset@entry=99, ftype=ftype@entry=-1)
> at packet-ieee80211.c:13242
> 13242 gboolean isDMG = *((gboolean*)(p_get_proto_data(wmem_file_scope(),
> pinfo, proto_wlan, IS_DMG_KEY)));
>
> and i try the patch and no crash !
I'm not sure if I understand your comment...
The patch stops the crash - but I don't think it's the long term solution... or
rather, it might or might not be - I haven't investigated what the code expects
to happen, or if the code has an error previously.
It could just be a malformed packet that causes it, or it could be a
well-formed packet and the code is wrong somewhere. In the former case it
should probably do something better than DISSECTOR_ASSERT_NOT_REACHED(); in the
latter case, there's some code to fix somewhere. :)
You are receiving this mail because:
- You are watching all bug changes.