Wireshark-bugs: [Wireshark-bugs] [Bug 9851] Lua dissector TCP reassembly doesn't work as adverti

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 08 Mar 2014 00:12:44 +0000

Comment # 3 on bug 9851 from 
(In reply to comment #2)
> I mean basically using the tcp_dissect_pdus() method is just a convenience,
> right?  There's nothing you can't just do with the pinfo.desegment* stuff is
> there?

A dissector *could* manually both 1) use the pinfo.desegment* stuff and 2)
handle multiple PDUs per TCP segment - and, in fact, they *did* do so, at one
point.  Inr5394 I "[Made] a "tcp_dissect_pdus()" with the standard loop for a
TCP segment, extracting PDUs from it and possibly doing reassembly." and
"[Made] the COPS, DNS, DSI, Gryphon, and SCCP dissectors use it.", so that,
instead of dissectors all having to do 1) and 2), most dissectors could just
call tcp_dissect_pdus() and supply the necessary information.

(That change doesn't show up in the history of epan/dissectors/packet-tcp.c in
the Git repository, probably because the SVN-to-Git converter couldn't handle
moves/renames in SVN, perhaps because SVN, while handling them better than CVS,
still handles them a bit awkwardly.)

You are receiving this mail because:
  • You are watching all bug changes.