Wireshark-bugs: [Wireshark-bugs] [Bug 9424] Implement ZigBee Green Power dissector

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Sat, 01 Mar 2014 21:53:35 +0000

Comment # 23 on bug 9424 from 
While updating the dissector a bit to create/use two extended value strings and
do a few other quite minor changes[1], I noticed the following code:

In function:

    dissect_zbee_nwk_gp_cmd_commissioning()

under:
     if (comm_options & ZBEE_NWK_GP_CMD_COMMISSIONING_OPT_MANUFACTURER_INFO) 

        ...
        if (ms_ext_options & ZBEE_NWK_GP_CMD_COMMISSIONING_MS_EXT_MMIP) {
            /* Get Manufacturer Device ID. */
            switch (manufacturer_id) {
                case ZBEE_NWK_GP_MANUF_ID_GREENPEAK:


Is this OK ? Does the Manufacturer Device ID need to be be fetched from the tvb
as per the comment ?

Thanks

[1]https://code.wireshark.org/review/#/c/441/

You are receiving this mail because:
  • You are watching all bug changes.