Wireshark-bugs: [Wireshark-bugs] [Bug 9733] New: Lua: wtap_filetypes.TSPREC_ variable names are

Date: Sat, 08 Feb 2014 04:27:50 +0000
Bug ID 9733
Summary Lua: wtap_filetypes.TSPREC_ variable names are missing from the Lua global table
Classification Unclassified
Product Wireshark
Version 1.11.x (Experimental)
Hardware x86
OS Mac OS X 10.9
Status UNCONFIRMED
Severity Normal
Priority Low
Component Dissection engine (libwireshark)
Assignee [email protected]
Reporter [email protected]

Build Information:
wireshark 1.11.3 (wireshark-1.11.3-rc1-1589-gf966980-dirty from unknown)

Copyright 1998-2014 Gerald Combs <[email protected]> and contributors.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

Compiled (64-bit) with GTK+ 2.24.22, with Cairo 1.12.16, with Pango 1.36.1,
with
GLib 2.38.2, with libpcap, with libz 1.2.8, without POSIX capabilities, without
SMI, without c-ares, without ADNS, with Lua 5.2, without Python, with GnuTLS
3.1.10, with Gcrypt 1.5.3, with MIT Kerberos, without GeoIP, without PortAudio,
with AirPcap.

Running on Mac OS X 10.9.1, build 13B42 (Darwin 13.0.0), with locale
en_US.UTF-8, with libpcap version 1.5.3, with libz 1.2.8, GnuTLS 3.1.10, Gcrypt
1.5.3, without AirPcap.
Intel(R) Core(TM) i7 CPU       M 620  @ 2.67GHz

Built using clang 4.2.1 Compatible Apple LLVM 5.0 (clang-500.2.79).
--
The fix for bug 9712, which involved changing the make-init-lua.pl perl script
to handle the new C-code define names for filetypes in release 1.11,
unfortunately also stopped matching against the timestamp define names.

Arguably the timestamp ones should never have been matched to begin with, at
least not by the same regex function, because they're not "filetypes".  But
they've been matched and exported into the Lua table forever, so we'll break
backward-compat if we don't keep doing it. Ugh.

I'll submit a fix into gerrit... reluctantly. :)

The good news is I caught this bug using a new test script I wrote which
verifies previous release's Lua stuff didn't disappear.  I'll submit that
separately when I get a chance to clean it up, hopefully next week.


You are receiving this mail because:
  • You are watching all bug changes.