Comment # 22
on bug 8070
from Shoichi Sakane
(In reply to comment #18)
> Shoichi:
>
> While looking at packet-coap.c I noticed what seems to me to be a minor bug
> in dissect_coap_opt_uri_query().
>
> Specifically: it seems to me that the g_strlcat marked below should be
> concatenating to 'coap_uri_query' and not to 'coap_uri_str'.
>
> If you can confirm, I'll make the change.
>
> Thanks
>
> -------
>
> dissect_coap_opt_uri_query(tvbuff_t *tvb, proto_item *head_item,proto_tree
> *subtree, gint offset, gint opt_length)
> {
> const guint8 *str = NULL;
>
> [...]
>
> if (opt_length == 0) {
> str = nullstr;
> } else {
> str = [...];
> ==> g_strlcat(coap_uri_str, str, sizeof(coap_uri_str));
> }
> [...]
>
> }
You are correct. There are copy-and-paste problem.
You are receiving this mail because:
- You are watching all bug changes.