Michael Mann
changed
bug 9607
| What |
Removed |
Added |
| Attachment #12510 Flags |
|
review_for_checkin?
|
Comment # 27
on bug 9607
from Michael Mann
Created attachment 12510 [details]
Wiretap refactored, take 1
I may have gone too far down the rabbit hole, but I took a shot at starting to
refactor Wiretap and breaking structures down into "generally useful fields for
dissection" and "capture specific". Since I envision this as a "base" for
Wiretap and Filetap, I when with the "wft" prefix for "common" functionality.
For now it all still lives in the Wiretap library because I didn't want to
officially break it out without some discussion. Certain fields could
certainly be moved between "common" and "capture specific", but its the initial
break that was the most difficult (to compile).
The "architectural" changes can be found in cfile.h, wtap.h, wtap-int.h and
(new file) wftap-int.h. Most of the other (painstaking) changes were really
just the result of compiling those new architecture changes.
Feedback is of course appreciated. This was my final task before tackling
Gerrit/git, so once I have the new setup ready, I'll get more serious about
committing this (barring objections)
You are receiving this mail because:
- You are watching all bug changes.