Wireshark-bugs: [Wireshark-bugs] [Bug 9054] vwr libwiretap heuristic file type recognizer mis-id

Date: Mon, 20 Jan 2014 00:18:18 +0000

Comment # 7 on bug 9054 from
(In reply to comment #6)
> Thanks for the commit Guy. I felt this was a good idea but didn't have time
> to work on it myself.
> 
> Since magic numbers take precedence over file extensions, there is still a
> risk that non-magic files may be incorrectly recognized by magic number
> checks due to coincidental matches, but hopefully this should be rare.

Given that we ran the magic-number checks before the non-magic-number checks
before this, that's more of a case of "that problem remains" rather than "that
problem was introduced", so my inclination, for now, is to keep it simple(r)
and worry about that only if we get a report of such a mismatch.


You are receiving this mail because:
  • You are watching all bug changes.