[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 9638

What	Removed	Added
Attachment #12473 Flags		review_for_checkin-

Comment # 1 on bug 9638 from Alexis La Goutte

Comment on attachment 12473 [details]
contains sample packets, source code and diff file for version 1.10.6

Need some rework :

The code don't build on Linux :
packet-lwm.c: In function 'dissect_lwm_heur':
packet-lwm.c:120:77: error: unused parameter 'data' [-Werror=unused-parameter]
packet-lwm.c: In function 'dissect_lwm':
packet-lwm.c:243:9: error: passing argument 3 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:243:9: error: passing argument 4 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c:244:9: error: implicit declaration of function 'check_col'
[-Werror=implicit-function-declaration]
packet-lwm.c:290:11: error: passing argument 3 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:290:11: error: passing argument 4 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c:342:19: error: passing argument 3 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:342:19: error: passing argument 4 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c:442:3: error: passing argument 3 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:442:3: error: passing argument 4 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c: In function 'dissect_lwm_cmd_frame_ack':
packet-lwm.c:503:4: error: passing argument 3 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:503:4: error: passing argument 4 of 'expert_add_info_format' makes
pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c: In function 'dissect_lwm_cmd_frame_route_err':
packet-lwm.c:571:23: error: passing argument 3 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:571:23: error: passing argument 4 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c: In function 'dissect_lwm_cmd_frame_route_req':
packet-lwm.c:645:23: error: passing argument 3 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:645:23: error: passing argument 4 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'
packet-lwm.c: In function 'dissect_lwm_cmd_frame_route_reply':
packet-lwm.c:721:23: error: passing argument 3 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'struct expert_field *' but argument
is of type 'int'
packet-lwm.c:721:23: error: passing argument 4 of 'expert_add_info_format'
makes pointer from integer without a cast [-Werror]
In file included from packet-lwm.c:40:0:
../../epan/expert.h:141:1: note: expected 'const char *' but argument is of
type 'int'


There is a news expert framework on Wireshark 1.11, please use trunk to dev.

Also prefer proto_tree_add_item when it is possible (no need to have local
variable)

Please also attach a pcap sample (and a attach by file and only diff no need c
or h file and no zipped file)

packet-lvm.h will be reuse by other dissector ? if no include in #define and
others stuff in packet-lvm.c

The code is check/fuzzed ? (also check code with fix-encoding-args, using TRUE
/ FALSE in lasted proto_tree_add_item is deprecated)

---

      You are receiving this mail because:

• You are watching all bug changes.