Pascal Quantin
changed
bug 9472
| What |
Removed |
Added |
| Attachment #12361 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 11
on bug 9472
from Pascal Quantin
Comment on attachment 12361 [details]
A better patch(?)
Hi,
I spotted three issues when playing a bit with this patch:
- the dissection of Message Center Time Stamp is not correct.
According to the spec, the encoding is in BCD, not hexa:
"all date and time fields contain two 4-bit BCD numbers giving the decimal
value of the field. For example, if the year is 1996, the YEAR field contains
'10010110'."
With this patch the byte 0x13 is interpreted as 19 instead of 13. Moreover the
months should be in the 1-12 range and not 0-11.
- the computation of the required_octs variable in text_decoder() does not seem
correct. For example if you have fill_bits=1 and 160 characters coded in 7bits
encoding, then required_octs should be 141 and not 140. Would the correct
formula be:
required_octs = (num_bits + fill_bits + 7) / 8;
?
- the reserved bits displayed after the decoded text is not correct: it does
not take into account the extra byte needed in case of fill bits (like the
previous point) and does not select the right bits in case of GSM 7 bits
encoding (it should take the MSB and not LSB I think).
You are receiving this mail because:
- You are watching all bug changes.