Roland Knall
changed
bug 9572
| What |
Removed |
Added |
| Attachment #12360 Flags |
|
review_for_checkin?
|
Comment # 7
on bug 9572
from Roland Knall
Created attachment 12360 [details]
openSAFETY: Remove unneccessary call to second sub-dissector
I took a deeper look. This patch (only for the openSAFETY dissector, the mbtcp
patch might still be applied), removes the whole if-clause. It was introduced
in an earlier version of the dissector as a means to ensure, that SercosIII
frames get dissected beside the openSAFETY dissection. This is not necessary
anymore, and after testing it with various test-captures I had lying around the
whole clause should be removed, as it is useless in my opinion.
You are receiving this mail because:
- You are watching all bug changes.