Wireshark-bugs: [Wireshark-bugs] [Bug 3290] TRY_TO_FAKE_THIS_ITEM disables bounds errors

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Thu, 19 Dec 2013 23:13:06 +0000

Comment # 35 on bug 3290 from 
(In reply to comment #34)
> Does this still deserve to be In Progress? I think it can be marked as fixed
> now, and the remaining stale patches denied?

Well keep in mind that so far only proto_tree_add_item() and
proto_tree_add_bits_item() are protected; the other proto_tree_add_XXX() APIs
are not.

Though, OTOH, I guess those other APIs are (in the common case) protected
because the thing's value you're adding to the tree has (presumably) already
been fetched with tvb_get_XXX().  Maybe the others don't really need
protection...

Oh, but then there's also the ptvcursor API.  That should be checked.

You are receiving this mail because:
  • You are the assignee for the bug.
  • You are watching all bug changes.