Michael Mann
changed
bug 9472
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
CONFIRMED
|
| Ever confirmed |
|
1
|
Comment # 9
on bug 9472
from Michael Mann
(In reply to comment #8)
2. I didn't add that parameter someone else did, they changed it
> from using the private_data pointer. The parameter is used the ...user_data
> element calls dis_field_udh() based on that parameter being set true in one
> of the other element dissectors. Not my design. However, this is the same
> thing you wanted me to do to get rid of the globals in packet-ansi_a.c!
My apologies, I missed the use. The design itself isn't bad, I just didn't see
where it was being used.
4. In this case
> there is no good reason. In some of the other dissectors I have done this
> because typcially I don't want to use 16-bit bitmasks mixed in with 8-bit
> bitmasks. I don't like the way it looks. So it really depends on all of
> the fields combined. I will change these ones because there isn't any
> visual reason for it to kept this way.
I think having to piece together a value from separate items would be annoying
enough that it aesthetics won't trump it. It also makes it odd if the field
has an hf_ entry (which it should).
You are receiving this mail because:
- You are watching all bug changes.