Michael Mann
changed
bug 9472
| What |
Removed |
Added |
| Attachment #12350 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 7
on bug 9472
from Michael Mann
Comment on attachment 12350 [details]
Changes for CMAS and better text display
1. See r54244, I believe you want to follow this convention and not use
g_convert_with_iconv (looks like you missed "free maintenance" by a day)
2. has_private_data isn't used, yet it's passed through a lot of functions.
Justification?
3. If you use proto_tree_add_uint_format_value instead of
proto_tree_add_uint_format on an hf_ field with a non-zero bitmask, you get the
"bitstring" for free (and don't need other_decode_bitfield_value). There are
stil several places this could be applied.
4. Can you explain (for my own curiosity) the difference between "Number of
fields (MSB)" and "Number of fields (LSB)". why are they separate fields with
different bitmasks? Wouldn't a single 16-bit bitmask and ENC_LITTLE_ENDIAN or
ENC_BIG_ENDIAN be simpler?
You are receiving this mail because:
- You are watching all bug changes.