Michael Mann
changed
bug 9471
| What |
Removed |
Added |
| Attachment #12154 is obsolete |
|
1
|
| Attachment #12286 is obsolete |
|
1
|
| Attachment #12297 Flags |
|
review_for_checkin?
|
Comment # 9
on bug 9471
from Michael Mann
Created attachment 12297 [details]
ANSI-A cleanup
This patch builds off of Michael Lum's original patch that drastically reduced
the number of proto_tree_add_texts as well as a few enhancements. My additions
were mostly in replacing switch statements with value_strings and removing some
more other_decode_bitfield_value calls. Also put the value_strings from
packet-ansi-tsb58.[ch] into packet_ansi_a.[ch] just to avoid file polution
(even if the values will be shared by other dissectors)
Michael (Lum) - if you like this I can commit it and we can move to the other
things I'd like addressed within this bug:
1. Removal of global variables (especially the "strings" that are passed
between functions)
2. Removal of other_decode_bitfield_value (should be able to tbe handled within
the default formatting of proto_tree_add_xxx)
You are receiving this mail because:
- You are watching all bug changes.