Michael Mann
changed
bug 4574
| What |
Removed |
Added |
| Attachment #4424 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 14
on bug 4574
from Michael Mann
Comment on attachment 4424 [details]
new patch based on the current development trunk
I compared dissect_iscsi/dissect_iscsiexpert_msg and
dissect_iscsi_pdu/dissect_iscsiexpert_pdu functions (which to me are the real
meat of the dissector) and they don't look different enough to justify a new
dissector (just A LOT more conversation data). If anything the "expert"
dissector has weaker heuristics just so it can flag it as an error later on.
We now have an "expert API", and designwise I don't think a separate module
(rules) is needed to keep track of such things. Everything should be "inline"
with the dissector and included in a single file.
We've also recently switched to using Qt over GTK+, so the GUI portion needs to
be updated accordingly.
You are receiving this mail because:
- You are the assignee for the bug.
- You are watching all bug changes.