Wireshark-bugs: [Wireshark-bugs] [Bug 9478] GSM SMS UDH fill bits still incorrect

Date: Thu, 28 Nov 2013 21:17:11 +0000

Comment # 6 on bug 9478 from
Hi Pascal I don't think its perfectly valid as per page 61 of 3GPP TS 23.040: 
http://www.etsi.org/deliver/etsi_ts/123000_123099/123040/04.02.00_60/ts_123040v040200p.pdf 

The fill bits are part of the UDH specified in TS 23.040.
The fill bits are meant to pad up to the septet boundary and must therefore
be in the format I originally had.

There were two issues with the UDH support in packet-ansi_637.c.

One was this one which was highlighting the incorrect bits (and showing
non-zero).

The second problem is that the &bit returned by dis_field_udh() was the
number of fill bits.  It was being passed to decode_7_bits() which requires
the number of "unused" bits in oct.
I was planning on fixing this in a re-worked packet-ansi_637.c submission.

My sample is 7bit ASCII.


You are receiving this mail because:
  • You are watching all bug changes.