Comment # 4
on bug 9482
from Chris Maynard
(In reply to comment #3)
> I committed something similar in r53617 - before I saw this bug and the
> patch :-(
It's OK. I had missed dissect_fc_ifcp() anyway. Maybe it would be better to
change dissect_fc_helper() so it returns either 0 or tvb_length(tvb), depending
on whether fc_data is NULL or not, then it's only done in 1 place?
> It looks like a generic problem. A new-style dissector can never be sure
> that its data parameter contains something useful. Do we have to add a check
> everywhere?
Yes, I think so. Any dissector expecting data should probably verify that data
!= NULL and reject the packet if it is.
You are receiving this mail because:
- You are watching all bug changes.