Pascal Quantin
changed
bug 9444
| What |
Removed |
Added |
| Attachment #12104 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 9444
from Pascal Quantin
Comment on attachment 12104 [details]
Initial patch
Hi Peter,
you will find below a few comments:
- paramtypenames[] value_string array lacks a {0, NULL} at the end
- rtpptoxy_add_parameter should be renamed to rtpproxy_add_parameter I guess :)
- I'm not a big fan of recursive functions. Could we do a loop that calls
rtpproxy_add_parameter several times and do the "if(realsize == 0) return;"
check outside of the function (in the loop) instead? Moreover it might be
better to do a <= 0 check in case offset ends being bigger than realsize
because of a malformed packet (did not check closely whether it could happen or
not).
Other than that it seems OK.
Thanks,
Pascal.
You are receiving this mail because:
- You are watching all bug changes.