Wireshark-bugs: [Wireshark-bugs] [Bug 9397] Add RTP/RTCP dissector setup based on the replies fo

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 25 Nov 2013 21:46:18 +0000

changed bug 9397

What Removed Added
Attachment #12175 Flags review_for_checkin? review_for_checkin-

Comment # 2 on bug 9397 from 
Comment on attachment 12175 [details]
2nd version

Hi Peter,

when looking at the code of rtp_add_address/rtcp_add_address (that call
conversation_new) it looks like you do not need to copy the address in file
scoped memory. A packet scoped memory or a local variable will be sufficient as
conversation_new calls SE_COPY_ADDRESS. Could you give it a try and confirms it
works fine?
Moreover your patch does not compile on Windows. You lack the following
include:
#ifdef HAVE_WINSOCK2_H
#include <winsock2.h>       /* needed to define AF_ values on Windows */
#endif

Thanks,
Pascal.

You are receiving this mail because:
  • You are watching all bug changes.