Comment # 9
on bug 9361
from Michael Mann
Comment on attachment 12160 [details]
AllJoyn dissector unzipped
I can see that an attempt was made to clear up licensing issues, but I'm not
sure if its still acceptable. Jorg?
The dissector looks very good except I found it odd that you "swapped" item and
tree variable names in handle_message_header_body() (header_tree and
header_item) and carried that through to a few other function calls.
proto_item and proto_tree both resolve to the same type I believe, it just
caught me a little off guard. Not really worth fixing unless you want to.
You are receiving this mail because:
- You are watching all bug changes.