Wireshark-bugs: [Wireshark-bugs] [Bug 8279] Add support for Android Logcat logs, text files and

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 19 Nov 2013 18:21:40 +0000

Comment # 38 on bug 8279 from 
(In reply to comment #3)
> > 3/ wiretap/logcat.c
> >
> > 208 wth->phdr.ts.secs  = GINT32_FROM_LE(*((gint32 *) &buf[3 * 4]));
> > 209 wth->phdr.ts.nsecs = GINT32_FROM_LE(*((gint32 *) &buf[4 * 4]));
> >
> > Please check wiretap/wtap-int.h but I believe pletohl() should be used.
> 
> pletohl seems to be for unsigned, but there is needed signed variables.

simple cast to (int) (pletohl(...)) won't work?
I somehow can understand if Android cares about dates < 1970, but why signed
nanosecs? :>

You are receiving this mail because:
  • You are watching all bug changes.