[bugzilla-daemon@xxxxxxxxxxxxx]

Alexis La Goutte changed bug 8594

What	Removed	Added
Attachment #12078 Flags	review_for_checkin?	review_for_checkin-

Comment # 28 on bug 8594 from Alexis La Goutte

Comment on attachment 12078 [details]
802.11ad patch v7

Hi,

the patch don't apply on the trunk

Also there is some (minor) warnings when build with Clang analyser
packet-ieee80211.c:15316:17: warning: Value stored to 'offset' is never read
                offset += 2;
                ^         ~
packet-ieee80211.c:15327:11: warning: Value stored to 'offset' is never read
          offset += add_ff_beamforming_ctrl(hdr_tree, tvb, offset,
ctrl_type_subtype);
          ^        
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
packet-ieee80211.c:15332:11: warning: Value stored to 'offset' is never read
          offset += add_fixed_field(hdr_tree, tvb, pinfo, offset,
FIELD_SECTOR_SWEEP_FB);
          ^        
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
packet-ieee80211.c:15339:11: warning: Value stored to 'offset' is never read
          offset += add_fixed_field(hdr_tree, tvb, pinfo, offset,
FIELD_BEAMFORMED_LINK_MAINTAINCE);
          ^        
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
packet-ieee80211.c:15346:11: warning: Value stored to 'offset' is never read
          offset += 6;

add_ff_beacon_interval_ctrl and add_ff_beacon_interval_ctrl_detail is the some
code ? (only arg for get value)

Why in dissect_ieee80211_extension get cc and dis value directly ? (no need to
pass in add_ff_beacon_interval_ctrl_detail

There is no a bitmask error in Sector Sweep ? (between Direction and CDOWN)

for beacon Interval Control, it is no possible to split flag in 2 group ? (a
group with 2 bytes and other group with 4 bytes ?) (i known there is not yet
FT_UINT64 Bitmask...)

---

      You are receiving this mail because:

• You are watching all bug changes.