Comment # 23
on bug 8594
from Evan Huus
(In reply to comment #22)
> Corrected some whitespace issues as well as a typo found by checkAPIs.pl.
> Overall the patch looks pretty good, but is there an easier way to do the
> IS_80211AD macro? Perhaps use p_add_proto_data/p_get_proto_data?
Probably. The search for "Channel frequency" will match a couple of different
fields, I'm not sure if that's intended or not:
- ppi.80211-common.chan.freq
- radiotap.channel.freq
- radiotap.xchannel.freq
- wlan.channel_frequency
If the intention was to match any one of them then *_proto_data() could get
tricky, but I suspect there was one in particular being looked for. Jalil,
which field are you looking for specifically?
You are receiving this mail because:
- You are watching all bug changes.