Wireshark-bugs: [Wireshark-bugs] [Bug 9413] Remove usb_conv_info_t from packet_info

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Tue, 12 Nov 2013 08:47:56 +0000

Comment # 7 on bug 9413 from 
I propose to completely remove usb_data_t, like that:

struct _usb_conv_info_t {
    guint16  bus_id;
    guint8   device_address;
    guint8   endpoint;
    gint     direction;

    guint16 deviceVendor;   
    guint32 deviceProduct;      

    guint16 interfaceClass;    
    guint16 interfaceSubclass;
    guint16 interfaceProtocol;  
    guint8  interfaceNum;      

    wmem_tree_t *transactions;
    usb_trans_info_t *usb_trans_info; 
    void *class_data;    
};

*usb_trans_info (etc.) should be NULL (only if still unknown) for dissectors
using usb_data_t.

deviceVendor, deviceProduct is similar to bus_id/device_address - always
available: used to decode payload in dissector tables: "usb.device" and
"usb.product" (hint: only "usb.protocol" is not related to
interfaceClass/interfaceSubclass/interfaceProtocol because this time
"usb.protocol" is releted to "deviceClass/deviceSubClass/deviceProtocol" (in
sum: one "device" may have few "interfaces")).

Thanks Michael for your work. It seems that you simplify USB dissectors for me.

You are receiving this mail because:
  • You are watching all bug changes.