Comment # 4
on bug 9419
from didier gautheron
(In reply to comment #2)
> Two questions:
>
> 1/ Can we pass NULL edt instead of adding another variable to
> add_packet_to_packet_list()?
Yes it is, cf patch V2
>
> 2/ You missed checking for TAPs, AFAIR it can breaks some statistics which
> limits their output to active dfilter (like Statistics -> Conversation) can
> you confirm if it's an issue?
It's not an issue, the line
create_proto_tree = (dfcode != NULL || have_tap );
deals with that.
Didier
You are receiving this mail because:
- You are watching all bug changes.