Bill Meier
changed
bug 9367
| What |
Removed |
Added |
| Status |
IN_PROGRESS
|
RESOLVED
|
| Resolution |
---
|
FIXED
|
Comment # 7
on bug 9367
from Bill Meier
Ok: I've committed your original patch plus some fixes by me in SVN #53078.
packet-mq.h
-----------
I chose to fix the macro expansions in the spirit of your original patch so
that GET_VALSV() could be used (rather than just doing the substitution as you
did in your revised patch).
#define DEF_VALSEXT(A) DEF_VALSEXT1(GET_VALSV(A))
#define DEF_VALSEXT1(A) DEF_VALSEXT2(A)
#define DEF_VALSEXT2(A) value_string_ext A##_ext = VALUE_STRING_EXT_INIT(A)
(See "Macros that call other macros that stringify or concatenate"
in http://gcc.gnu.org/onlinedocs/cpp/Argument-Prescan.html#Argument-Prescan ).
Having done the above, I've marked the updated patch as not accepted although
there's obviously nothing actually wrong with it.
If you prefer that your macro fix from the updated patch be used instead of the
way I did the fix please let me know and I'll make the change.
In addition I've put '#if 0' around the macro definitions of DEF_VALSEXTX and
DEF_VALREXTX since they are not currently used.
packet-mq-pcf.c
---------------
There was a -Wshadow warning; I fixed it by by making the following change in
dissect_mqpcf_parm() under 'if (uCount == (guint32)-1)'
- guint32 uCnt=0;
+ uCnt=0;
Again: Thanks for the patch !
You are receiving this mail because:
- You are watching all bug changes.