Comment # 5
on bug 9373
from Alexis La Goutte
(In reply to comment #4)
> (In reply to comment #3)
>
> > Good but there is a small problem found by checkhf
> > ERROR: NO ARRAY: epan/dissectors/packet-ieee80211.c,
> > hf_ieee80211_tpc_element_id
> > ERROR: NO ARRAY: epan/dissectors/packet-ieee80211.c, hf_ieee80211_tpc_length
>
> This error is probably shown because I didn't add these fields to
> hf_register_info. That was not done because they were pretty useless (nobody
> is going to filter on the constant values of these two fields). Should I use
> proto_tree_add_text instead?
>
You need to add filter to hf_register_info (there is a ASSERT if no field is
available)
and proto_tree_add_text is not recommended
> > Do you plan also to fix also TODO in TAG_MEASURE_REQ ?
>
> Nope, I have not seen such packets. If someone feels that this is necessary,
> attach a capture file and I might have a look at it.
OK
>
> About these lines:
> proto_tree_add_item(tpc_tree, hf_ieee80211_tpc_element_id, tvb, offset,
> 1, ENC_NA);
> proto_tree_add_item(tpc_tree, hf_ieee80211_tpc_length, tvb, offset,
> 1, ENC_NA);
> ...
>
> I think it should become offset,1 offset,2, etc. Is that correct?
No offset+1, 1, ENC_NA);
offset+2, 1, ENC_NA);
or increment offset after proto_tree_add_item
proto_tree_add_item(tpc_tree, hf_ieee80211_tpc_element_id, tvb, offset, 1,
ENC_NA);
offset += 1;
proto_tree_add_item(tpc_tree, hf_ieee80211_tpc_length, tvb, offset, 1, ENC_NA);
You are receiving this mail because:
- You are watching all bug changes.