Bill Meier
changed
bug 9361
| What |
Removed |
Added |
| Status |
UNCONFIRMED
|
INCOMPLETE
|
| Ever confirmed |
|
1
|
Comment # 2
on bug 9361
from Bill Meier
A few initial comments:
1. ISTR that "version 2 and only version 2" in the following may be
an issue for Wireshark. I'll let others comment on this.
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 and
+ * only version 2 as published by the Free Software Foundation.
2. The following is missing:
* $Id$
*
* Wireshark - Network traffic analyzer
* By Gerald Combs <[email protected]>
* Copyright 1998 Gerald Combs
*
[...]
* You should have received a copy of the GNU General Public License along
* with this program; if not, write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
See doc/README.disector and doc/packet-PROTOABBREV.c
3. col_...() fcns shouldn't be called under 'if (tree)'
(e.g., in parse_answers().
4. The editor mode-lines say "no tabs" but there are tabs for some of the
indentation. Also: there are a few lines with trailing whitespace.
5. In general, tvb_reported_length...() should be used rather than
tvb_length...(),
You are receiving this mail because:
- You are watching all bug changes.