[bugzilla-daemon@xxxxxxxxxxxxx]

Bug ID	9359
Summary	Make ASN.1 SESSION_DATA_STRUCTURE private to ASN.1 context only
Classification	Unclassified
Product	Wireshark
Version	SVN
Hardware	All
OS	All
Status	CONFIRMED
Severity	Enhancement
Priority	Low
Component	Dissection engine (libwireshark)
Assignee	bugzilla-admin@wireshark.org
Reporter	mmann78@netscape.net
Attachment #11943 Flags	review_for_checkin?

Created attachment 11943 [details]
SESSION_DATA_STRUCTURE made more private

Build Information:
SVN 52991
--
In an effort to reduce the use of pinfo->private_data (and some true global
variables), I converted the ASN.1 dissectors that use pinfo->private_data to
exchange a SESSION_DATA_STRUCTURE to instead only exchange it in the context of
ASN.1.  This meant converting dissectors to the "new" style to pass the
SESSION_DATA_STRUCTURE as well as providing a pointer to it in
asn1_ctx_t.private_data.  Yes, it's still "private data", but it's not used by
all dissectors like pinfo->private data is.

Wanted those with more ASN.1 experience to sanity check this and/or possibly
suggest a different asn1_ctx_t member to use.

Patch also includes some minor cleanup of whitespace and trees.

---

      You are receiving this mail because:

• You are watching all bug changes.