Jeff Morriss
changed
bug 9323
| What |
Removed |
Added |
| Status |
CONFIRMED
|
RESOLVED
|
| Resolution |
---
|
FIXED
|
Comment # 35
on bug 9323
from Jeff Morriss
(In reply to comment #34)
> (In reply to comment #33)
> > Don't we still have the issue that we claim the string doesn't have to be
> > NULL terminated but it does? Should we just give up on FT_STRING?
>
> I don't think we are claiming that, I think the documentation is just really
> confusing and poorly worded.
[...]
> Therefore while we never explicitly say the string must be null-terminated,
> the assumption is that it must be (and as far as I know all other callers
> assume it must be as well).
Ah, makes a lot of sense. I wasn't thinking about it that way. Hopefully
r52984 will help prevent people from making the same mistake.
> > Another thought I had was that the only reason the HTTP dissector is
> > formatting the string here is to clean it up. Which we arguably should be
> > doing for the values, too, before the user can use them in "Apply as Filter"
> > or whatever (as the comments in tvb_get_string_enc() suggest).
>
> This is a whole can of worms related to the email I sent to -dev on string
> handling. Continue this discussion there?
Yes.
(In reply to comment #32)
> As far as I can tell nothing here actually needs backporting, so if there
> are no problems with the current patch this can be closed.
I think it's good, closing.
You are receiving this mail because:
- You are watching all bug changes.