Wireshark-bugs: [Wireshark-bugs] [Bug 9333] USB: NFC: Final work on PN532, add PN532_HCI dissect

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: bugzilla-daemon@xxxxxxxxxxxxx
Date: Mon, 28 Oct 2013 11:49:12 +0000

Comment # 19 on bug 9333 from 
(In reply to comment #18)
> Created attachment 11911 [details]
> [PATCH 6] USB/PN532: Fix dissector to use new dissector *data instead of 
> private_data
> 
> I am working on converting Bluetooth dissectors from private_data to
> new_dissector *data. But this time for USB. Please check attached patch 6,
> this should fix issue with PN532 over USB_CCID.

Thanks for the patch. That works much better with my CCID/USB traces. 

FWIW - not a complaint, but whilst I can sort-of understand your rationale (in
terms of implementation ease? or spec-closeness?) it might be worth segmenting
the ISO 14443-B "ATQB Response" into PUPI, Application Data, and AFI values, to
make filtering by PUPI/UID easier in the InListPassiveTarget, and InAutoPoll
responses.

You are receiving this mail because:
  • You are watching all bug changes.