İbrahim Can Yüce
changed
bug 9217
| What |
Removed |
Added |
| Attachment #11912 Flags |
|
review_for_checkin?
|
Comment # 20
on bug 9217
from İbrahim Can Yüce
Created attachment 11912 [details]
new s5066dts dissector code patch, making 11859 as obsolete.
>> I committed the CRC functions to r52774 to make the dissector patch simpler, >> but the dissector itself needs work.
Thanks for your effort Michael.
>> 1. Remove the (non-preference) global variables. They should just be
>> function parameters to the subdissecting functions.
Unnecessary global definitions are removed except for the mandatory header
fields, preference and error variables etc.
>> 2. If CRC is returned in little-endian value, then the value should be
>> checked in little endian (tvb_get_letohl) so cpdu_crc doesn't need to be
>> "swapped".
I wasn't aware of such a call that you mentioned, used it. thanks.
3. What platform did you compile this on? I'm guessing Windows and "more
picky" compilers may complain with more warnings. I only have a Windows
compiler too, but experience says gcc will generate more warnings (unused
function parameters that don't have _U_ with them). If someone has access,
please post the compiler warnings here.
Nope, I've built that on an 32 bit x86 machine with gcc 4.7.2 and haven't
encountered any warnings.
You are receiving this mail because:
- You are watching all bug changes.