[bugzilla-daemon@xxxxxxxxxxxxx]

Bill Meier changed bug 9280

What	Removed	Added
Status	IN_PROGRESS	INCOMPLETE

Comment # 13 on bug 9280 from Bill Meier

1. Ok: With this patch the compiler error message (when building with
the OSX-10.6-x64 compiler) is as follows:

netscaler.c: In function 'nstrace_read_v30':
netscaler.c:1238: warning: implicit conversion shortens 64-bit value into a
32-bit value.

(I'll look at this myself a bit more tomorrow).


2. This patch still has tabs for indentation.

   As previously requested, please use indentation in the patch which
   matches the current netscaler.c indentation (4 spaces in this case).

   Also: This patch has lines with trailing whitespace. Please remove
   trailing whitespace before submitting a new patch.

3. I've now tested exporting a file in netscaler v3 format (using the latest
   SVN which has a fix for Bug 39271) and found that the export doesn't work. 

   Specifically, there are several functions in netscaler.c which have 
   code like the following:

        if (wdh->file_type == WTAP_FILE_NETSCALER_1_0)
        {
            ...
        } else if (wdh->file_type == WTAP_FILE_NETSCALER_2_0)
        {
            ...
        } else
        {
            g_assert_not_reached();
            return FALSE;
        }

     When trying to export a V3 format file, the 'g_assert_not_reached()'
     is hit and Wireshark exits.

     Note: Testing 'file write' functionality needs to be done
           using 'File ! Export Specified Packets'.

           'File ! Save As' just copies the file if the capture
           being dissected was read from a file (and the output
           format requested matches the input file format).

---

      You are receiving this mail because:

• You are watching all bug changes.