Michael Mann
changed
bug 9283
| What |
Removed |
Added |
| Attachment #11804 is obsolete |
|
1
|
| Attachment #11804 Flags |
review_for_checkin?
|
|
| Attachment #11811 is obsolete |
|
1
|
| Attachment #11811 Flags |
review_for_checkin?
|
|
| Attachment #11812 is obsolete |
|
1
|
| Attachment #11812 Flags |
review_for_checkin?
|
|
| Attachment #11813 is obsolete |
|
1
|
| Attachment #11813 Flags |
review_for_checkin?
|
|
| Attachment #11814 is obsolete |
|
1
|
| Attachment #11814 Flags |
review_for_checkin?
|
|
| Attachment #11815 Flags |
|
review_for_checkin-
|
Comment # 5
on bug 9283
from Michael Mann
Created attachment 11815 [details]
All flowmods dissection
The patches were simple and straightforward enough that I just combined them
all into one (because I think all could be committed in a single revision).
Patch also includes checkhf.pl fix that was already present in dissector.
Overall very good, but the things that need addressing:
1. Current proto_tree_add_text calls look like candidates for the expert info
API (mostly proto_tree_add_expert() with type PI_UNDECODED)
2. There are some FT_NONE type fields that appear to be "tree headers" which is
usually designated for proto_tree_add_text. Since the work was already put it
to add filters it's not that big a deal, but something to consider.
You are receiving this mail because:
- You are watching all bug changes.