Michael Mann
changed
bug 9074
| What |
Removed |
Added |
| Attachment #11448 is obsolete |
|
1
|
| Attachment #11448 Flags |
review_for_checkin?
|
|
| Attachment #11449 is obsolete |
|
1
|
| Attachment #11449 Flags |
review_for_checkin?
|
|
| Attachment #11450 is obsolete |
|
1
|
| Attachment #11450 Flags |
review_for_checkin?
|
|
Comment # 4
on bug 9074
from Michael Mann
Created attachment 11808 [details]
IMSI Based Filtering patch (condensed)
Made a single patch that combines all functionality. Some review comments
1. packet-ranap.c is an ASN.1 dissector and the source is generated. Don't
modify it directly, modify the "source" in asn1\ranap (as shown in patch)
2. The strdup() call will leak memory, so you probably want to replace it with
a wmem call.
3. The provided capture doesn't contain the sccp.assoc.imsi field or execute
any of the new packet-sccp.c functionality. Are you sure this is the correct
capture?
4. This piece of functionality is small enough that it can be considered a
single patch, no need to break it up per file, especially when there are
compile dependencies.
You are receiving this mail because:
- You are watching all bug changes.