Michael Mann
changed
bug 9267
| What |
Removed |
Added |
| Attachment #11772 Flags |
review_for_checkin?
|
review_for_checkin-
|
Comment # 2
on bug 9267
from Michael Mann
Comment on attachment 11772 [details]
paquet-mq more detaileld filed, display enhancement
1. packet-mq.c fails checkAPIs.pl
Error: the blurb for hf_mq_caut_PwdMaxLen ("mq.caut.pwdmaxlen") has trailing
spa
ce in /cygdrive/c/wireshark/epan/dissectors/packet-mq.c
Error: the blurb for hf_mq_id_CapFlag1 ("mq.id.idflags") has trailing space in
/
cygdrive/c/wireshark/epan/dissectors/packet-mq.c
Error: the blurb for hf_mq_msgreq_MQMDVers ("mq.msgreq.mqmdvers") has trailing
s
pace in /cygdrive/c/wireshark/epan/dissectors/packet-mq.c
2. Why reformat the license template in packet-mq-base.c?
3. Consider using proto_tree_add_bitmask() for the groups of boolean values.
4. Would it be possible to separate the "new functionality" from "whitespace
formatting"
5. Has this code been fuzztested?
6. Can you please provide a sample capture that exercises this code?
You are receiving this mail because:
- You are watching all bug changes.