Comment # 40
on bug 7893
from Michael Mann
Comment on attachment 11595 [details]
[PATCH 5] Bluetooth: AVDTP: Add support for Content Protection type SCMS-T
1. It appears the normal method of interfacing with the rtp dissector is to
register a "payload type". Does bluetooth not have an official "payload type"
so its dissectors have to be "hacked" in specifically?
2. Does it make more sense to pass the BT data into the RTP dissector (and
possibly create a "generic" interface for passing data to RTP), rather than
using private_data? I checked and no current dissector interacting with RTP
uses either private_data or passes data in.
Overall I don't like the BT dissectors getting special/specific treatment in
the dissector when it appears hooks are already in place.
(related but not directed at the patch) Why are dissectors checking for an rtp
dissector before "registering" an address (and do nothing otherwise). Should
that checking be internal to the rtp dissector? (which I assume is always
present).
You are receiving this mail because:
- You are watching all bug changes.